fix(feedback): show dev note when trying to retrieve image in ExpoGo #4900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0e42017+dirty | 387.33 ms | 399.30 ms | 11.97 ms |
| 7d3c3cb+dirty | 395.20 ms | 413.24 ms | 18.04 ms |
| 940bd65+dirty | 408.45 ms | 419.75 ms | 11.30 ms |
| df5da5d+dirty | 415.54 ms | 456.96 ms | 41.42 ms |
| b4d6bde+dirty | 390.51 ms | 385.60 ms | -4.91 ms |
| 1f1c420+dirty | 383.31 ms | 386.98 ms | 3.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0e42017+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 7d3c3cb+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 940bd65+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| df5da5d+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| b4d6bde+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 1f1c420+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b4d6bde+dirty | 1223.22 ms | 1243.56 ms | 20.34 ms |
| 7d3c3cb+dirty | 1226.39 ms | 1227.10 ms | 0.71 ms |
| 1f1c420+dirty | 1216.77 ms | 1214.48 ms | -2.29 ms |
| df5da5d+dirty | 1235.98 ms | 1243.41 ms | 7.43 ms |
| 940bd65+dirty | 1216.88 ms | 1225.23 ms | 8.35 ms |
| 0e42017+dirty | 1225.89 ms | 1231.63 ms | 5.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b4d6bde+dirty | 2.63 MiB | 3.77 MiB | 1.14 MiB |
| 7d3c3cb+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 1f1c420+dirty | 2.63 MiB | 3.77 MiB | 1.14 MiB |
| df5da5d+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 940bd65+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 0e42017+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b4d6bde+dirty | 1218.73 ms | 1223.26 ms | 4.53 ms |
| 7d3c3cb+dirty | 1214.56 ms | 1234.53 ms | 19.97 ms |
| 1f1c420+dirty | 1238.06 ms | 1234.04 ms | -4.02 ms |
| df5da5d+dirty | 1226.82 ms | 1234.88 ms | 8.06 ms |
| 940bd65+dirty | 1224.39 ms | 1215.57 ms | -8.82 ms |
| 0e42017+dirty | 1235.77 ms | 1247.43 ms | 11.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b4d6bde+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| 7d3c3cb+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| 1f1c420+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| df5da5d+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 940bd65+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| 0e42017+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 940bd65 | 466.31 ms | 458.52 ms | -7.79 ms |
| 1f1c420 | 403.32 ms | 411.98 ms | 8.66 ms |
| b4d6bde | 425.51 ms | 417.37 ms | -8.14 ms |
| 0e42017 | 402.23 ms | 415.04 ms | 12.81 ms |
| df5da5d | 425.55 ms | 432.96 ms | 7.41 ms |
| 7d3c3cb | 444.85 ms | 456.65 ms | 11.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 940bd65 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 1f1c420 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| b4d6bde | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 0e42017 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| df5da5d | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 7d3c3cb | 17.75 MiB | 20.15 MiB | 2.40 MiB |
|
Just thought for next time (this RP is already released). Although small, these are user/dev facing changes, it would make sense to me to mention in changelog. |
Thank you for the feedback @krystofwoldrich 🙇 Noted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Show dev note when trying to retrieve image in ExpoGo
💡 Motivation and Context
Fixes #4852
💚 How did you test it?
Manual
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog